save entries of token_offset_mapping as lists in document metadata
#356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArneBinder
changed the title
token_offset_mapping as lists in metadata to fix deserialization
ArneBinder
changed the title
token_offset_mapping as lists in metadata to fix deserializationtoken_offset_mapping as lists in document metadata
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... to fix deserialization. Serializing and deserializing
token_offset_mappingproduces lists of lists in any way (json does not know tuples), so we save the entries (start and end offset) as lists in the first place. Otherwise, this breaks equality checks with deserialized documents.