(de-)serialize document_type when calling DatasetDict.(to|from)_json()
#346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…zed document type
…ut try to load a metadata.json file and use the document_type from there (if it is not explicitly specified)
ArneBinder
changed the title
document_type when calling DatasetDictdocument_type when calling DatasetDict.(to|from)_json()
ArneBinder
added a commit
to ArneBinder/pytorch-ie-hydra-template-1
that referenced
this pull request
Sep 18, 2023
ArneBinder
added a commit
to ArneBinder/pytorch-ie-hydra-template-1
that referenced
this pull request
Sep 18, 2023
* require pytorch-ie>=0.24.2 because of ArneBinder/pytorch-ie#346 * JsonSerializer.(dump|read)(): split parameter path to path + optional file_name and add optional parameters metadata_file_name and split; save|read document_type to|from metadata file; allow to overwrite any default_kwargs in __call__ * remove mandatory document_type from from_serialized_documents dataset config * adjust readme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, we serialize the
document_typewhen callingDatasetDict.to_json(). Thedocument_typeis saved in a filemetadata.jsonin the output path. And it is tried to load it from there when callingDatasetDict.from_json()if nodocument_typeis specified (which is now optional for this method).