Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar to
TaskModules
,DocumentMetric
s require documents of a certain type as input. This PR adds the functionality to letDocumentMetrics
s signal what document type they need.In detail:
RequiresDocumentTypeMixin
that defines the class variableDOCUMENT_TYPE
and the propertydocument_type
(which returnsDOCUMENT_TYPE
per default). It also defines the methodconvert_dataset()
that checks for several edge cases before callingdataset.to_document_type(self.document_type)
RequiresDocumentTypeMixin
forDocumentMetric
and also forTaskModule
document_type
toDocumentStatistic
s that will be returned when callingDocumentStatistic.document_type
(it overwritesDOCUMENT_TYPE
)(Iterable)Dataset(Dict).to_document_type()
: we now also allow converters that are registered for document types that are subclasses of the requested type (e.g. if we have a converter forDocWithEntitiesAndRelations
, but just needDocWithEntities
, we still use that converter)