Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hf_hub_mixin.py to fix push_to_hub=True #339

Merged
merged 5 commits into from
Sep 13, 2023
Merged

Conversation

ArneBinder
Copy link
Owner

@ArneBinder ArneBinder commented Sep 13, 2023

... with current code from huggingface_hub/hub_mixin.py.

This also:

  • adds post_prepare() to PieTaskModuleHFHubMixin which is called when loading from pretrained and calls _post_prepare() in TaskModule
  • rename:
    • PyTorchIEBaseModelHubMixin -> PieBaseHFHubMixin
    • PyTorchIEModelHubMixin -> PieModelHFHubMixin
    • PyTorchIETaskmoduleModelHubMixin -> PieTaskModuleHFHubMixin

This fixed #261.

@ArneBinder ArneBinder changed the title Update hf hub mixin Update hf_hub_mixin.py Sep 13, 2023
@ArneBinder ArneBinder merged commit bba5e6f into main Sep 13, 2023
@ArneBinder ArneBinder deleted the update_hf_hub_mixin branch September 13, 2023 23:03
@ArneBinder ArneBinder changed the title Update hf_hub_mixin.py Update hf_hub_mixin.py to fix push_to_hub=True Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

push_to_hub=True is broken
1 participant