do not try to infer the document_type from the function in (Iterable)Dataset.map()
#337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ArneBinder
added a commit
to ArneBinder/pytorch-ie-hydra-template-1
that referenced
this pull request
Sep 13, 2023
ArneBinder
added a commit
to ArneBinder/pytorch-ie-hydra-template-1
that referenced
this pull request
Sep 13, 2023
ArneBinder
added a commit
to ArneBinder/pytorch-ie-hydra-template-1
that referenced
this pull request
Sep 13, 2023
* use pytorch-ie@dont_infer_doc_type_in_dataset_map * remove result_document_type because of ArneBinder/pytorch-ie#337 * add comments that reference the source code * use pytorch-ie 0.24.0 since it was released with ArneBinder/pytorch-ie#337
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR, we re-use the original document type when calling
(Iterable)Dataset.map()if noresult_document_typeis provided. This clarifies the semantics because we do not change the document type except that it is explicitly provided. With this we also do not rely on (maybe wrong) return type annotations anymore and we can use generic functions in map that do not change the document type at all (e.g. trimming spans) which is a quite common case.This is a breaking change for the case that
map()is called with a function that has an annotated return type which is different than the original document type of the dataset.