Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix tokenize_document() with slow tokenizer #34

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

ArneBinder
Copy link
Owner

@ArneBinder ArneBinder commented Jan 11, 2024

This fixes #29.

TODO:

  • add tests
  • implement the actual fix

@ArneBinder ArneBinder added the bug Something isn't working label Jan 11, 2024
@ArneBinder ArneBinder changed the title fix tokenize_docuement() with slow tokenizer fix tokenize_document() with slow tokenizer Jan 11, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5f96e5a) 95.62% compared to head (dcb7330) 95.62%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #34   +/-   ##
=======================================
  Coverage   95.62%   95.62%           
=======================================
  Files          40       40           
  Lines        3316     3316           
=======================================
  Hits         3171     3171           
  Misses        145      145           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tokenize_document() doesn't work if the model does not support fast tokenizer
2 participants