-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PointerNetworkTaskModuleForEnd2EndRE
: add reversed relations
#144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #144 +/- ##
==========================================
- Coverage 95.52% 95.49% -0.03%
==========================================
Files 61 61
Lines 5134 5173 +39
==========================================
+ Hits 4904 4940 +36
- Misses 230 233 +3 ☔ View full report in Codecov by Sentry. |
…terNetworkTaskModuleForEnd2EndRE
ArneBinder
force-pushed
the
pointer_re_tm/add_reversed_relations
branch
from
November 13, 2024 18:18
140b026
to
7dd49bc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the parameters
add_reversed_relations
andsymmetric_relations
forPointerNetworkTaskModuleForEnd2EndRE
(in analogy to their implementation inRETextClassificationWithIndicesTaskModule
).IMPORTANT: In production, this should make use of
document.deduplicate_annotations()
from pytorch-ie v0.31.3 ArneBinder/pytorch-ie#436 because otherwise duplicated annotations will occur in the predictions!Potential follow-up: Outsource to
ReversedRelationsMixture
.