Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PointerNetworkTaskModuleForEnd2EndRE: add reversed relations #144

Merged
merged 20 commits into from
Nov 13, 2024

Conversation

ArneBinder
Copy link
Owner

@ArneBinder ArneBinder commented Nov 13, 2024

This PR implements the parameters add_reversed_relations and symmetric_relations for PointerNetworkTaskModuleForEnd2EndRE (in analogy to their implementation in RETextClassificationWithIndicesTaskModule).

IMPORTANT: In production, this should make use of document.deduplicate_annotations() from pytorch-ie v0.31.3 ArneBinder/pytorch-ie#436 because otherwise duplicated annotations will occur in the predictions!

Potential follow-up: Outsource to ReversedRelationsMixture.

@ArneBinder ArneBinder added the enhancement New feature or request label Nov 13, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 13, 2024

Codecov Report

Attention: Patch coverage is 92.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 95.49%. Comparing base (c481fb4) to head (2d6d1d0).

Files with missing lines Patch % Lines
...ules/taskmodules/pointer_network_for_end2end_re.py 92.50% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #144      +/-   ##
==========================================
- Coverage   95.52%   95.49%   -0.03%     
==========================================
  Files          61       61              
  Lines        5134     5173      +39     
==========================================
+ Hits         4904     4940      +36     
- Misses        230      233       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArneBinder ArneBinder force-pushed the pointer_re_tm/add_reversed_relations branch from 140b026 to 7dd49bc Compare November 13, 2024 18:18
@ArneBinder ArneBinder merged commit d1ad3a9 into main Nov 13, 2024
2 checks passed
@ArneBinder ArneBinder deleted the pointer_re_tm/add_reversed_relations branch November 13, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants