Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add visualization for AM dataset cards. #97

Merged
merged 16 commits into from
Jan 19, 2024

Conversation

idalr
Copy link
Collaborator

@idalr idalr commented Jan 11, 2024

In this PR, we add images in README.md's from https://github.com/ArneBinder/pie-document-level/tree/main/argumentation-mining/documentation/corpora, according to #96. As well, we review the information in those dataset cards one more time.

  • aae2
  • abstrct
  • argmicro
  • cdcp
  • sciarg
  • scidtb_argmin

The content in dataset_builders/hf/ would be migrated to HuggingFace/DFKI-SLT, once this PR is complete.

Copy link

codecov bot commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e8238db) 95.22% compared to head (c310e25) 95.22%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #97   +/-   ##
=======================================
  Coverage   95.22%   95.22%           
=======================================
  Files          22       22           
  Lines        1402     1402           
=======================================
  Hits         1335     1335           
  Misses         67       67           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@idalr idalr requested a review from ArneBinder January 16, 2024 13:31
Copy link
Owner

@ArneBinder ArneBinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks very good. Just some minor points below.

Also, I just merged the content for the HF dataset cards (argmicro, cdcp, and scidtb_argmin), so you can delete the respective files from this PR.

Note: Next time, I think it is fine to directly create PRs for the respective HF dataset cards at https://huggingface.co/DFKI-SLT.

dataset_builders/pie/abstrct/README.md Outdated Show resolved Hide resolved
dataset_builders/pie/cdcp/README.md Outdated Show resolved Hide resolved
dataset_builders/pie/sciarg/README.md Outdated Show resolved Hide resolved
dataset_builders/pie/scidtb_argmin/README.md Outdated Show resolved Hide resolved
@idalr idalr requested a review from ArneBinder January 19, 2024 15:12
@ArneBinder ArneBinder merged commit 8072a91 into main Jan 19, 2024
4 checks passed
@ArneBinder ArneBinder deleted the add_visualization_for_AM_dataset_cards branch January 19, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants