Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add abstrct dataset #68

Merged
merged 24 commits into from
Dec 19, 2023
Merged

add abstrct dataset #68

merged 24 commits into from
Dec 19, 2023

Conversation

ArneBinder
Copy link
Owner

@ArneBinder ArneBinder commented Nov 25, 2023

In this PR, we add AbsTRCT - an argumentation-mining dataset, according to the description in #10.

@ArneBinder ArneBinder force-pushed the add_abstrct_dataset branch 3 times, most recently from 29aa021 to 4f900f4 Compare November 27, 2023 11:09
@idalr idalr force-pushed the add_abstrct_dataset branch 2 times, most recently from 8737058 to 5af593c Compare December 11, 2023 15:48
Copy link

codecov bot commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (856ca5d) 94.72% compared to head (172fc14) 95.15%.
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #68      +/-   ##
==========================================
+ Coverage   94.72%   95.15%   +0.43%     
==========================================
  Files          19       21       +2     
  Lines        1289     1342      +53     
==========================================
+ Hits         1221     1277      +56     
+ Misses         68       65       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner Author

@ArneBinder ArneBinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good, just some minor points, see below.

dataset_builders/pie/abstrct/abstrct.py Outdated Show resolved Hide resolved
tests/dataset_builders/pie/test_abstrct.py Show resolved Hide resolved
tests/dataset_builders/pie/test_abstrct.py Show resolved Hide resolved
tests/dataset_builders/pie/test_abstrct.py Outdated Show resolved Hide resolved
@idalr
Copy link
Collaborator

idalr commented Dec 19, 2023

While the AbstRCT dataset has no fragmented spans, we directly converted the dataset to BratDocumentWithMergedSpans, as a single-variant version ("default") in 612466b.

Updates:

Copy link
Owner Author

@ArneBinder ArneBinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good, just some minors.

dataset_builders/pie/abstrct/README.md Outdated Show resolved Hide resolved
dataset_builders/pie/abstrct/README.md Outdated Show resolved Hide resolved
dataset_builders/pie/abstrct/abstrct.py Outdated Show resolved Hide resolved
tests/dataset_builders/pie/test_abstrct.py Outdated Show resolved Hide resolved
tests/dataset_builders/pie/test_abstrct.py Show resolved Hide resolved
tests/dataset_builders/pie/test_abstrct.py Outdated Show resolved Hide resolved
tests/dataset_builders/pie/test_abstrct.py Outdated Show resolved Hide resolved
tests/dataset_builders/pie/test_abstrct.py Outdated Show resolved Hide resolved
tests/dataset_builders/pie/test_abstrct.py Outdated Show resolved Hide resolved
tests/dataset_builders/pie/test_abstrct.py Outdated Show resolved Hide resolved
@ArneBinder ArneBinder merged commit 4796b1e into main Dec 19, 2023
4 checks passed
@ArneBinder ArneBinder deleted the add_abstrct_dataset branch December 19, 2023 23:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants