Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add aae2 dataset #64

Closed
wants to merge 57 commits into from
Closed

add aae2 dataset #64

wants to merge 57 commits into from

Conversation

ArneBinder
Copy link
Owner

@ArneBinder ArneBinder commented Nov 23, 2023

In this PR, we add aae2, another AM dataset, as per described in #10.

Requires: #66 and #61 (see below)

TODO:

IMPORTANT: This PR is a bit messed up, the content of sciarg (#61) slipped into it. We will fix this as soon as #61 is merged.

IMPORTANT: This PR is still messed up. Therefore, we will continue to add this dataset in another PR (#92)

Copy link

codecov bot commented Nov 23, 2023

Codecov Report

Attention: 27 lines in your changes are missing coverage. Please review.

Comparison is base (856ca5d) 94.72% compared to head (ca85954) 93.58%.
Report is 37 commits behind head on main.

Files Patch % Lines
dataset_builders/pie/aae2/aae2.py 59.01% 25 Missing ⚠️
...uilders/pie/scientific_papers/scientific_papers.py 95.12% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #64      +/-   ##
==========================================
- Coverage   94.72%   93.58%   -1.14%     
==========================================
  Files          19       22       +3     
  Lines        1289     1403     +114     
==========================================
+ Hits         1221     1313      +92     
- Misses         68       90      +22     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ArneBinder ArneBinder requested a review from idalr November 24, 2023 20:10
@ArneBinder ArneBinder removed the request for review from idalr November 25, 2023 01:16
@ArneBinder ArneBinder force-pushed the add_aae2_dataset branch 4 times, most recently from 1658760 to c9a4127 Compare November 27, 2023 11:14
@idalr idalr mentioned this pull request Dec 21, 2023
3 tasks
@ArneBinder
Copy link
Owner Author

Closing in favor of #92.

@ArneBinder ArneBinder closed this Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants