Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AM dataset argmicro #56

Merged
merged 29 commits into from
Dec 7, 2023
Merged

Add AM dataset argmicro #56

merged 29 commits into from
Dec 7, 2023

Conversation

idalr
Copy link
Collaborator

@idalr idalr commented Nov 21, 2023 •
edited
Loading

As described in #10, we add a new argument mining dataset - ArgMicro.
This includes:

  • PIE dataset builder: pie/argmicro.py
  • dataset card: pie/argmicro/README.md
  • test file: test_argmicro.py
  • new dataset card for HF: README.md in 282733d

@codecov Codecov
Copy link

codecov bot commented Nov 21, 2023 •
edited
Loading

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (4310e2f) 93.78% compared to head (8f2e6a6) 94.24%.

Files Patch % Lines
dataset_builders/pie/argmicro/argmicro.py 97.36% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #56      +/-   ##
==========================================
+ Coverage   93.78%   94.24%   +0.45%     
==========================================
  Files          15       16       +1     
  Lines        1046     1198     +152     
==========================================
+ Hits          981     1129     +148     
- Misses         65       69       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@idalr idalr mentioned this pull request Nov 21, 2023
Open
6 tasks
ArneBinder
ArneBinder requested changes Nov 21, 2023
View reviewed changes
Copy link
Owner

@ArneBinder ArneBinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See below.

dataset_builders/pie/argmicro/README.md Outdated Show resolved Hide resolved
tests/dataset_builders/pie/test_argmicro.py Outdated Show resolved Hide resolved
dataset_builders/pie/argmicro/README.md Outdated Show resolved Hide resolved
dataset_builders/pie/argmicro/README.md Show resolved Hide resolved
tests/dataset_builders/pie/test_argmicro.py Outdated Show resolved Hide resolved
tests/dataset_builders/pie/test_argmicro.py Outdated Show resolved Hide resolved
tests/dataset_builders/pie/test_argmicro.py Outdated Show resolved Hide resolved
tests/dataset_builders/pie/test_argmicro.py Outdated Show resolved Hide resolved
@ArneBinder ArneBinder changed the title Add AM dataset ArgMicro Add AM dataset argmicro Nov 21, 2023
@ArneBinder ArneBinder force-pushed the add_dataset_argmicro branch 4 times, most recently from 7dc9531 to 7bb66d1 Compare November 26, 2023 20:34
@idalr idalr requested a review from ArneBinder December 1, 2023 14:14
ArneBinder
ArneBinder requested changes Dec 1, 2023
View reviewed changes
Copy link
Owner

@ArneBinder ArneBinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found just one more thing.

dataset_builders/pie/argmicro/README.md Outdated Show resolved Hide resolved
@ArneBinder ArneBinder merged commit 5664d1d into main Dec 7, 2023
4 checks passed
@ArneBinder ArneBinder deleted the add_dataset_argmicro branch December 7, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArneBinder ArneBinder ArneBinder approved these changes

Assignees

@idalr idalr

Labels
new dataset
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@idalr @ArneBinder