Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AM dataset SciDTB_Argmin #54

Merged
merged 15 commits into from
Nov 17, 2023
Merged

Add AM dataset SciDTB_Argmin #54

merged 15 commits into from
Nov 17, 2023

Conversation

idalr
Copy link
Collaborator

@idalr idalr commented Nov 16, 2023

As described in #10, we add a new argument mining dataset - SciDTB_Argmin.
This includes:

NOTE: This requires pytorch-i>=0.29.1!

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0586d39) 93.07% compared to head (abb84dd) 93.51%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #54      +/-   ##
==========================================
+ Coverage   93.07%   93.51%   +0.43%     
==========================================
  Files          17       18       +1     
  Lines        1286     1356      +70     
==========================================
+ Hits         1197     1268      +71     
+ Misses         89       88       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@idalr idalr requested a review from ArneBinder November 16, 2023 17:38
Copy link
Owner

@ArneBinder ArneBinder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Please fix these minor issues.

dataset_builders/pie/scidtb_argmin/README.md Outdated Show resolved Hide resolved
dataset_builders/pie/scidtb_argmin/README.md Outdated Show resolved Hide resolved
dataset_builders/pie/scidtb_argmin/README.md Outdated Show resolved Hide resolved
dataset_builders/hf/scidtb_argmin/README.md Outdated Show resolved Hide resolved
dataset_builders/hf/scidtb_argmin/README.md Outdated Show resolved Hide resolved
tests/dataset_builders/pie/test_scidtb_argmin.py Outdated Show resolved Hide resolved
tests/dataset_builders/pie/test_scidtb_argmin.py Outdated Show resolved Hide resolved
tests/dataset_builders/pie/test_scidtb_argmin.py Outdated Show resolved Hide resolved
@ArneBinder ArneBinder merged commit 789ee6c into main Nov 17, 2023
4 checks passed
@ArneBinder ArneBinder deleted the add_dataset_scidtb_argmin branch November 17, 2023 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants