Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add concatenate datasets method #147

Closed
wants to merge 57 commits into from
Closed

add concatenate datasets method #147

wants to merge 57 commits into from

Conversation

kai-car
Copy link
Collaborator

@kai-car kai-car commented Aug 7, 2024

Implementing a method for the concatenation of multiple datasets into one single dataset.

kai-car and others added 30 commits July 19, 2024 16:52
Co-authored-by: ArneBinder <[email protected]>
* added all data properties to doc and removed metadata

* introduced new Span Types

* adjusted example_to_document method

* fixed related tests
* adjusted document_to_example to match changes

* adjusted related tests

* introduced converter method to Comagc class
* improved understanding of relation label UNIDENTIFIED
* if no inference rule is applicable no relation will be added to the doc
* label is None should be  label is not None instead
* should cover the case when a document has no relation, i.e. no inference rule applies
* tests inferring a relation label
* enables concatenation of multiple pie-datasets

* tests still missing
kai-car and others added 26 commits August 7, 2024 16:39
Co-authored-by: ArneBinder <[email protected]>
* added all data properties to doc and removed metadata

* introduced new Span Types

* adjusted example_to_document method

* fixed related tests
* adjusted document_to_example to match changes

* adjusted related tests

* introduced converter method to Comagc class
* improved understanding of relation label UNIDENTIFIED
* if no inference rule is applicable no relation will be added to the doc
* label is None should be  label is not None instead
* should cover the case when a document has no relation, i.e. no inference rule applies
* tests inferring a relation label
* enables concatenation of multiple pie-datasets

* tests still missing
Copy link

codecov bot commented Aug 7, 2024

Codecov Report

Attention: Patch coverage is 83.16832% with 17 lines in your changes missing coverage. Please review.

Project coverage is 90.89%. Comparing base (793fd57) to head (226f5ad).
Report is 3 commits behind head on main.

Files Patch % Lines
src/pie_datasets/core/dataset.py 10.52% 17 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #147      +/-   ##
==========================================
- Coverage   96.82%   90.89%   -5.94%     
==========================================
  Files           1       11      +10     
  Lines          63      955     +892     
==========================================
+ Hits           61      868     +807     
- Misses          2       87      +85     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kai-car kai-car closed this Aug 8, 2024
@kai-car kai-car deleted the concatenate-datasets branch August 8, 2024 07:44
@kai-car
Copy link
Collaborator Author

kai-car commented Aug 8, 2024

Error in branch creation, find the new pull request here #148. The associated branch is concat-datasets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant