-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add concatenate datasets method #147
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: ArneBinder <[email protected]>
Co-authored-by: ArneBinder <[email protected]>
Co-authored-by: ArneBinder <[email protected]>
not finished yet
* added all data properties to doc and removed metadata * introduced new Span Types * adjusted example_to_document method * fixed related tests
* adjusted document_to_example to match changes * adjusted related tests * introduced converter method to Comagc class
* improved understanding of relation label UNIDENTIFIED
* if no inference rule is applicable no relation will be added to the doc
Co-authored-by: ArneBinder <[email protected]>
Co-authored-by: ArneBinder <[email protected]>
* label is None should be label is not None instead
* should cover the case when a document has no relation, i.e. no inference rule applies
* tests inferring a relation label
* enables concatenation of multiple pie-datasets * tests still missing
Co-authored-by: ArneBinder <[email protected]>
Co-authored-by: ArneBinder <[email protected]>
Co-authored-by: ArneBinder <[email protected]>
not finished yet
* added all data properties to doc and removed metadata * introduced new Span Types * adjusted example_to_document method * fixed related tests
* adjusted document_to_example to match changes * adjusted related tests * introduced converter method to Comagc class
* improved understanding of relation label UNIDENTIFIED
* if no inference rule is applicable no relation will be added to the doc
Co-authored-by: ArneBinder <[email protected]>
Co-authored-by: ArneBinder <[email protected]>
* label is None should be label is not None instead
* should cover the case when a document has no relation, i.e. no inference rule applies
* tests inferring a relation label
* enables concatenation of multiple pie-datasets * tests still missing
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #147 +/- ##
==========================================
- Coverage 96.82% 90.89% -5.94%
==========================================
Files 1 11 +10
Lines 63 955 +892
==========================================
+ Hits 61 868 +807
- Misses 2 87 +85 ☔ View full report in Codecov by Sentry. |
Error in branch creation, find the new pull request here #148. The associated branch is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementing a method for the concatenation of multiple datasets into one single dataset.