Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement Dataset.from_documents #136

Merged
merged 9 commits into from
Aug 20, 2024
Merged

implement Dataset.from_documents #136

merged 9 commits into from
Aug 20, 2024

Conversation

ArneBinder
Copy link
Owner

@ArneBinder ArneBinder commented Jul 15, 2024

TODO:

  • add tests
  • maybe: IterableDataset.from_documents

@ArneBinder ArneBinder added the enhancement New feature or request label Jul 15, 2024
Copy link

codecov bot commented Jul 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.02%. Comparing base (38b9580) to head (3f1980b).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #136      +/-   ##
==========================================
+ Coverage   91.40%   92.02%   +0.62%     
==========================================
  Files          10       10              
  Lines         814      878      +64     
==========================================
+ Hits          744      808      +64     
  Misses         70       70              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kai-car kai-car changed the title implement Dataset.from_documents [WIP] implement Dataset.from_documents Aug 9, 2024
@kai-car kai-car marked this pull request as draft August 9, 2024 10:12
@kai-car kai-car marked this pull request as ready for review August 9, 2024 11:12
@ArneBinder ArneBinder merged commit 8605432 into main Aug 20, 2024
4 checks passed
@ArneBinder ArneBinder deleted the dataset_from_documents branch August 20, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants