Update tor_public_pool.sh #154
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added missing ; after then
| @@ -1,34 +1,39 @@ | |||
| function enable_tor_public_pool { | |||
| if [[ $OS == Mac ]] ; then no_mac ; return 1 ; fi | |||
| if [[ $OS == Mac ]]; then no_mac; return 1; fi | |||
There was a problem hiding this comment.
I don't mind much either way, but I use spaces before every ; all through Parmanode.
If I'm going to use C or C++, I don't use the space.
| if sudo grep "HiddenServiceDir $varlibtor/public_pool-service/" \ | ||
| $torrc | grep -v "^#" >$dn 2>&1 ; then true ; debug "true" ; else debug "else" | ||
| echo "HiddenServiceDir $varlibtor/public_pool-service/" | sudo tee -a $torrc >$dn 2>&1 | ||
| if sudo grep "HiddenServiceDir $varlibtor/public_pool-service/" $torrc | grep -v "^#" >$dn 2>&1; then |
There was a problem hiding this comment.
Fair enough, the original was ugly and uncalled for.
| if sudo grep "HiddenServicePort 5055 127.0.0.1:5052" \ | ||
| $torrc | grep -v "^#" >$dn 2>&1 ; then true ; else | ||
| echo "HiddenServicePort 5055 127.0.0.1:5052" | sudo tee -a $torrc >$dn 2>&1 | ||
| if sudo grep "HiddenServicePort 5055 127.0.0.1:5052" $torrc | grep -v "^#" >$dn 2>&1; then |
There was a problem hiding this comment.
Now that I look, it's probably better to have no else and put the code under "then" by adding a "!" before sudo
|
|
||
| set_terminal ; echo -e " | ||
| set_terminal |
There was a problem hiding this comment.
set_terminal ; echo -e "
is my commonly used style on hundreds of pages.
| ######################################################################################## | ||
| FYI, changes have been made to torrc file, and Tor has been restarted. | ||
| ######################################################################################## | ||
| " | ||
| enter_continue ; jump $enter_cont | ||
| enter_continue |
There was a problem hiding this comment.
Commonly used style, and helps the search if I want to refactor, looking for this specific line
ArmanTheParman
requested changes
Dec 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added missing ; after then