Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor:重构公招代码 #645

Closed
wants to merge 17 commits into from
Closed

refactor:重构公招代码 #645

wants to merge 17 commits into from

Conversation

EightyDollars
Copy link
Contributor

No description provided.

@EightyDollars EightyDollars force-pushed the dev_recruit branch 3 times, most recently from d739762 to fdf4ef7 Compare July 17, 2024 10:48
@ZhaoZuohong
Copy link
Contributor

方正雅宋是有版权的字体，不要提交到仓库里

@ZhaoZuohong
Copy link
Contributor

ZhaoZuohong commented Jul 18, 2024 •
edited
Loading

recruit.pkl 是怎样生成的？以后再加新词条时怎样维护？

@ZhaoZuohong
Copy link
Contributor

agent_token_first.png 或许截“首次获得”比较好？

@ZhaoZuohong
Copy link
Contributor

recruit_config 不要通过参数传给 RecruitSolver，直接走 arknights_mower.utils.config

@ZhaoZuohong
Copy link
Contributor

recruit_tags 方法中，把“根据词条计算招募结果”的逻辑与发邮件、识别等分开，为公招词条计算逻辑编写单元测试

@EightyDollars
Copy link
Contributor Author

agent_token_first.png 或许截“首次获得”比较好？

因为高级凭证正好和xxx的信物会在同一个区域，而且只是为了防止在初次获得的时候识别不出是开包界面，所以只要能识别出是开包就行

@EightyDollars
Copy link
Contributor Author

还差一个单元测试，明日再战

@EightyDollars
Copy link
Contributor Author

recruit_tags 方法中，把“根据词条计算招募结果”的逻辑与发邮件、识别等分开，为公招词条计算逻辑编写单元测试

计算结果是一个单独的recruit_cal方法,然后我试着摸了一个单元测试这样

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EightyDollars @ZhaoZuohong