A simple "Print flight controller banner statustext message contents"… #962
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterbarker
requested changes
Aug 4, 2024
examples/status_msg.py
Outdated
|
|
||
|
|
||
| def print_banner_messages(master): | ||
| '''Decode and print banner information from the flight controller''' |
There was a problem hiding this comment.
I'm a bit concerned by this "decode" bit here. Statustexts really should be opaque to software, they're really not a good way of transmitting data to automated systems.
An example decoding the AUTOPILOT_VERSION message would be good, 'though :-) Particularly because of the way we encode the board ID in that message.
Suggested change
| '''Decode and print banner information from the flight controller''' | |
| '''print banner information from the flight controller''' |
amilcarlucas
force-pushed
the
banner_example
branch
2 times, most recently
from
7572ddc
to
e001771
Compare
peterbarker
force-pushed
the
banner_example
branch
from
e001771
to
d5c7356
Compare
…" example print heartbeat and AUTOPILOT_VERSION information as well
peterbarker
force-pushed
the
banner_example
branch
from
d5c7356
to
1c8d601
Compare
|
Merged the commits, fixed the commit message and merged it. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… example