-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
save some log structure flash when features disabled #28788
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
../../libraries/AC_Avoidance/AC_Avoidance_Logging.cpp: In member function 'void AP_OABendyRuler::Write_OABendyRuler(uint8_t, bool, float, float, bool, float, const Location&, const Location&) const':
../../libraries/AC_Avoidance/AC_Avoidance_Logging.cpp:23:46: error: 'ahrs' is not a member of 'AP'
23 | yaw : (uint16_t)wrap_360(AP::ahrs().yaw_sensor * 0.01f),
| ^~~~
... that was the first error which popped up; consider using ./Tools/autotest/test_build_options.py
with --define-match-glob
to see if it picks up the others.
@@ -106,6 +107,9 @@ struct PACKED log_OD_Visgraph { | |||
int32_t Lon; | |||
}; | |||
|
|||
#if !AP_AVOIDANCE_ENABLED |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd prefer to put the positive case first - ie. don't negate this and put the empty case at the end.
Not all that fussed, mind you.
ok, thanks. Started a run with "--define-match-glob=AP*" - does that sound right? |
that error also happens with master, it doesn't have anything to do with this PR
produces:
|
644287f
to
198e975
Compare
Nope, |
a0ab0a6
to
e1366c1
Compare
put the positive clause first to be consistent across codebase
put the positive clause first to be consistent across codebase
put the positive clause first to be consistent across codebase
put the positive clause first to be consistent across codebase
put the positive clause first to be consistent across codebase
put the positive clause first to be consistent across codebase
5aecb81
to
99e7f51
Compare
this continues some work that @peterbarker has started. I ran across one of these while working on a different PR