autotest: Enabled old test and added new test on home alt reset #28758
+23
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Regarding Plane tests on Home Alt change during flight:
Details
Old test
The existing test should be passing since #24487, but it was malformed. It should be checking for the absolute altitude to be constant. The relative one is supposed to change.
New test
The new test tries to make the check a bit more explicit, by doing the Home alt change during a stable, level flight, instead of the end of the takeoff climb.
Testing
Before
The new test was passing even before #28675, as expected.
The cursor is at the moment of Home Alt change.
The TECS altitude was correctly changed:
TECS was getting reset, as expected:
The absolute altitude was roughly stable, but the TECS reset caused a dampened oscillation:
After
After #28675 TECS is shifting again:
but TECS does not reset:
and the altitude does not have a transient anymore: