Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autotest: Enabled old test and added new test on home alt reset #28758

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Georacer
Copy link
Contributor

Summary

Regarding Plane tests on Home Alt change during flight:

  • Enabled old disabled test that was already passing, but was malformed.
  • Created new test variant, where the altitude change occurs during stable level flight.

Details

Old test

The existing test should be passing since #24487, but it was malformed. It should be checking for the absolute altitude to be constant. The relative one is supposed to change.

New test

The new test tries to make the check a bit more explicit, by doing the Home alt change during a stable, level flight, instead of the end of the takeoff climb.

Testing

Before

The new test was passing even before #28675, as expected.
The cursor is at the moment of Home Alt change.

The TECS altitude was correctly changed:
Screenshot from 2024-11-27 12-19-15

TECS was getting reset, as expected:
Screenshot from 2024-11-27 12-19-23

The absolute altitude was roughly stable, but the TECS reset caused a dampened oscillation:
Screenshot from 2024-11-27 12-19-19

After

After #28675 TECS is shifting again:
Screenshot from 2024-11-27 12-20-48

but TECS does not reset:
Screenshot from 2024-11-27 12-20-55

and the altitude does not have a transient anymore:
Screenshot from 2024-11-27 12-20-51

@amilcarlucas
Copy link
Contributor

So does this close #5672? if yes you can add that to the PR description.

@Georacer
Copy link
Contributor Author

So does this close #5672? if yes you can add that to the PR description.

I closed this manually already, as it was not an issue anymore anyways.

@Georacer
Copy link
Contributor Author

Apparently this fails on SetHomeAltChange, I'll have to look more carefully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants