AP_DDS: Make GPS DDS features depend on GPS #28341
Open
+9
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
... this one definitely needs to compile :-) Not really sure what you're doing with that "NEEDS" variable, either... |
Ryanf55
force-pushed
the
dds-dependent-ifdefs-gps
branch
from
72d29f2 to
f2c0478
Compare
Could also call it Before: #if AP_DDS_NAVSATFIX_PUB_ENABLED || AP_DDS_STATIC_TF_PUB_ENABLED // And potentially more!
#include <AP_GPS/AP_GPS.h>
#endifAfter: #if AP_DDS_NEEDS_GPS
#include <AP_GPS/AP_GPS.h>
#endifThis pattern could be adopted in all the places we have: |
tridge
approved these changes
Jan 6, 2025
tridge
reviewed
Jan 6, 2025
Ryanf55
commented
Jan 6, 2025
peterbarker
requested changes
Jan 6, 2025
* Only allow DDS to share GPS data if you have GPS supported * Fix missing visualodom include Signed-off-by: Ryan Friedman <[email protected]>
Ryanf55
force-pushed
the
dds-dependent-ifdefs-gps
branch
from
b57bb3a to
2f8a758
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Make the DDS features that depend on GPS rely on
AP_GPS_ENABLED.Details
Follow up to #28177 where we hard-coded navsatfix enable flag to
1.If you disabled GPS on
masternow and enabled DDS, you would get a compile error,