Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MavlinkNumericUpDown: adjusted to consider scale for Min and Max values #3261

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tatsuy
Copy link
Contributor

@tatsuy tatsuy commented Dec 21, 2023

Implemented unit conversion for RTL_ALT's minimum and maximum values in Geo Fence screen to allow setting RTL Altitude[m] below 200m.

"RTL Altitude[m]" on the Geo Fence screen cannot be set to less than the current setting.
image

The setting must be changed in the Full Parameter List.

The cause was that the minimum value for RTL_ALT is 200 cm and the conversion of units is not taken into account.
In this PR, units are now taken into account for the minimum and maximum.

@meee1
Copy link
Contributor

meee1 commented Jan 12, 2024

i question this change. as i think it will have large effects on other params

@tatsuy
Copy link
Contributor Author

tatsuy commented Jan 14, 2024

Yes, it has an overall impact.
I have also confirmed the following other parameters.
PSC_VELXY_IMAX
PSC_ACCZ_IMAX
image

If this modification is not applied, it could inadvertently set an out-of-range value.
ex. set PSC_VELXY_IMAX to 4500 on Extended Tuning screen
image

It will set 4500*10 (the scale value)
image

I think it would be correct to consider scale in all parameters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants