Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Start Websocket Server to the MAVProxy console #1481

Merged
merged 1 commit into from
Nov 17, 2024

Conversation

Ryanf55
Copy link
Contributor

@Ryanf55 Ryanf55 commented Nov 8, 2024

Purpose

Add ability to add a websocket server in the MAVProxy menu. It's only added if wsproto is installed.

Related

Demo

mavproxy_1481_websocket_server.webm

Follow Up

  • Give users the ability to change which port number. The current one matches webtools.
    • Any tips on other places that open up a text box when you click?

@IamPete1
Copy link
Member

IamPete1 commented Nov 9, 2024

If you start on the same port as mission planner then Telemetry Dashboard should auto connect. That would be 56781, we could make that the default value too.

@Ryanf55
Copy link
Contributor Author

Ryanf55 commented Nov 9, 2024

If you start on the same port as mission planner then Telemetry Dashboard should auto connect. That would be 56781, we could make that the default value too.

Where's the 5863 come from?
image

I'm happy to switch.

@IamPete1
Copy link
Member

IamPete1 commented Nov 9, 2024

Where's the 5863 come from?

Its what I was using when I first started, just the SITL port I was using + 100. Completely arbitrary.

@Ryanf55 Ryanf55 force-pushed the websocket-start-option branch 2 times, most recently from 7f91b90 to 08f6608 Compare November 11, 2024 21:45
MAVProxy/modules/mavproxy_console.py Outdated Show resolved Hide resolved
MAVProxy/modules/mavproxy_console.py Outdated Show resolved Hide resolved
@Ryanf55 Ryanf55 force-pushed the websocket-start-option branch 2 times, most recently from 2784917 to 09a574d Compare November 11, 2024 23:38
MAVProxy/modules/mavproxy_console.py Outdated Show resolved Hide resolved
Copy link
Contributor

@peterbarker peterbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move to the "Link" menu.

@Ryanf55
Copy link
Contributor Author

Ryanf55 commented Nov 13, 2024

Please move to the "Link" menu.

@tridge Are you ok with Link menu? You originally recommended we not put it there, and instead in the MAVProxy menu.

@Ryanf55
Copy link
Contributor Author

Ryanf55 commented Nov 15, 2024

Please move to the "Link" menu.

@tridge Are you ok with Link menu? You originally recommended we not put it there, and instead in the MAVProxy menu.

Tridge is not heavily tied to the MAVProxy menu, and said either option is OK. "Link" doesn't yet do outputs. Another option is to customize the menu through the mavinit file, but that doesn't yet support a user-dialog popup to customize the port, or conditionally load depending if the dependencies are available.

I'll move it to "Link".

@Ryanf55
Copy link
Contributor Author

Ryanf55 commented Nov 15, 2024

Screencast.from.11-14-2024.09.25.41.PM.webm

Done! Here's the new demo.

@peterbarker peterbarker merged commit 335e1c9 into ArduPilot:master Nov 17, 2024
2 checks passed
@peterbarker
Copy link
Contributor

Merged, thanks!

@Ryanf55 Ryanf55 deleted the websocket-start-option branch November 17, 2024 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants