Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modules: grapher layout and file export fixed for Windows #1432

Merged
merged 5 commits into from
Dec 4, 2024

Conversation

stephendade
Copy link
Contributor

Fixed two issues with MAVExplorer graphs not working nicely:

  • Changed to "TkAgg" backend on Windows, as the "wxAgg" backend wasn't displaying the chart values (lower right) correctly
  • When saving graphs to file ("save" icon on graph window), made the suggested filename safer by removing problematic characters (ie Sensors/GPS/GPS Accuracy to Sensors_GPS_GPS_Accuracy)

@peterbarker
Copy link
Contributor

@MichelleRos this seems to say that graphing works for Stephen; could you test this PR to see if graphing actually works for you after this, please?

@MichelleRos
Copy link
Contributor

MichelleRos commented Nov 23, 2024

Just tested it. Graphing seems to be working, and the save icon does work on the "canned" graphs I tested, but when I tried just graphing something from the command line it threw this error and didn't bring up the dialog box:

Exception in Tkinter callback Traceback (most recent call last): File "tkinter\__init__.py", line 1921, in __call__ File "matplotlib\backends\_backend_tk.py", line 858, in save_figure File "MAVProxy\modules\lib\grapher.py", line 293, in <lambda> TypeError: 'NoneType' object is not iterable

Note that I've been using MAVExplorer via WSL rather than using the Windows one, so I don't know what did or didn't work before. 😅

(Though on MAVExplorer via WSL I don't think the save icon has ever worked for me. I've just been using a screenshot app when I want to get an image of a graph.)

@stephendade
Copy link
Contributor Author

Just tested it. Graphing seems to be working, and the save icon does work on the "canned" graphs I tested, but when I tried just graphing something from the command line it threw this error and didn't bring up the dialog box:

That's now been fixed.

I also added a few more fixes based upon https://discuss.ardupilot.org/t/mavproxy-version-in-windows/121556/10?u=stephendade:

  • Heli param definitions now included in build
  • Fixed up another graphing issue in Windows (magfit in MAVExplorer)
  • Modernised the Windows build scripts

@stephendade stephendade merged commit 02d9f7e into ArduPilot:master Dec 4, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants