include multiple encoding errors in OPEN_DRONE_ID_ARM_STATUS message #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tridge
requested changes
Mar 5, 2023
|
Implemented a new PR with the requested changes.
|
|
needs a rebase, sorry |
BluemarkInnovations
force-pushed
the
rid_multiple_errors_status
branch
from
6075f00
to
a302b59
Compare
|
did a rebase and squashed the commits. |
tridge
force-pushed
the
rid_multiple_errors_status
branch
from
a302b59
to
e0fd917
Compare
|
Seems to be ready for merge, see comment April 3. |
tridge
force-pushed
the
rid_multiple_errors_status
branch
from
e0fd917
to
ca64a22
Compare
|
@BluemarkInnovations i've cleaned up the string handling a bit |
tridge
approved these changes
Oct 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current implementation, the check_parse fails on the first error whenit encounters bad data in one of the RID packets.
In this PR, the function will collect all bad data errors and include the packets that fail in in the ARM status error field. This is useful in case the data stream has multiple errors. For instance if the system message has an error and the operator ID too, the current implementation would only return that the system message fails.