Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add edge case for boss bar to fix #319 #320

Closed
wants to merge 1 commit into from

Conversation

Intybyte
Copy link
Contributor

Fixes #319

@Archy-X
Copy link
Owner

Archy-X commented Sep 26, 2024

Pretty sure this was already fixed by cb43666 unless you still were able to reproduce it on the latest dev build.

@Intybyte
Copy link
Contributor Author

Pretty sure this was already fixed by cb43666 unless you still were able to reproduce it on the latest dev build.

I am not sure, however I remembered having the same issue while making my addon and testing around, better safe than sorry

@Archy-X
Copy link
Owner

Archy-X commented Sep 27, 2024

I tested that the previous commit already fixed any divide by zero case which was the cause, so I'm going to close this. Re-open if the issue crops up again.

@Archy-X Archy-X closed this Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Progress must be between 0.0 and 1.0 (NaN) error during PlayerItemConsumeEvent
2 participants