Ignore ABN_POSCHANGED message if work area didnt change #427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ty I'll try to test it on my PC and merge soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had a problem where the sidebar would get into an infinite loop of reloading/flickering when using the reserve space setting because every reload would trigger a new ABN_POSCHANGED message which would trigger another reload...
After every reload/repositioning I save the current work area. We can ignore all ABN_POSCHANGED messages unless the work area changes.
This PR also prevents unnecessary reloads when clicking on the edge of an unlocked taskbar.
The async delays in
SetAppBarandBindAppBar(Windows.cs) might now be obsolete but I wasn't 100% sure. Removing them worked on my machine.