Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support synchronously metrics publishing #18

Merged
merged 4 commits into from
Nov 28, 2024
Merged

Support synchronously metrics publishing #18

merged 4 commits into from
Nov 28, 2024

Conversation

evg-tso
Copy link
Member

@evg-tso evg-tso commented Sep 19, 2024

Changed

  • Support for a null executor, allowing for synchronous metrics publishing.
  • Verify openTelemetry and metricPrefix are not null in the OtelMetricPublisher constructor.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 19, 2024 •
edited
Loading

Test Results

8 files  8 suites   4s ⏱️
1 tests 1 ✅ 0 💤 0 ❌
8 runs  8 ✅ 0 💤 0 ❌

Results for commit bd07108.

♻️ This comment has been updated with latest results.

@evg-tso evg-tso requested a review from idantavor November 26, 2024 13:31
@evg-tso evg-tso merged commit 0d88b0b into main Nov 28, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lily-a-dev lily-a-dev lily-a-dev approved these changes

@idantavor idantavor idantavor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@evg-tso @idantavor @lily-a-dev