Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added capability to get Publisher provided extras from InMobi Adapter #679

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

neelabh-parui-inmobi
Copy link

  • Added null check for account ID.
  • Added capability to get Publisher Provided extras through MaxAdapterParamaters and passing it to InMobi SDK

@jplianghu
Copy link
Contributor

jplianghu commented Jul 4, 2024

Hi @neelabh-parui-inmobi,

Thank you for submitting this pull request. I've reviewed the changes and have some questions for clarification:

Added null check for account ID.

This functionality is already implemented in the adapter, so there may be no need to add it again.

Added capability to get Publisher Provided extras through MaxAdapterParamaters and passing it to InMobi SDK

Could you explain the purpose of this change? It appears you are aiming to pass parameters to the InMobi SDK via local extra parameters, which is not standard practice for us.
Typically, the Placement ID configured in the Ad Unit is sufficient for identifying the publisher and accessing any setup configurations on your dashboard. If the Placement ID does not meet your needs, you might consider adding additional fields.

Looking forward to your response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants