[Line] Call onAdHidden method when onDestroy. #376
+19
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Call onAdHidden method when onDestroy, because LINE SDK might close full-screen ad without calling onAdHidden method. - For apps implemented using Service API (https://developer.android.com/guide/components/services), LINE SDK closes a full-screen ad without calling onFiveAdClose method, when such app is closed during displaying a full-screen ad. - AppLovin SDK does not load the next ad for a while unless onInterstitialAdHidden / onRewardedAdHidden is called after finishing displaying a full-screen ad. As a result, - On app implemented by Service API - An user closes app while displaying full-screen Ad, then restarts app. In such case, AppLoving SDK does not load the next ad for a while. This change fixes the above issue. We verified patched LineMediationAdapter.java fixes the issue. The reproduced app with patched LineMediationAdapter.java does not reproduce the issue.
thomasmso
reviewed
Oct 6, 2022
| @@ -140,6 +143,18 @@ public void initialize(final MaxAdapterInitializationParameters parameters, fina | |||
| @Override | |||
| public void onDestroy() | |||
There was a problem hiding this comment.
onDestroy() will not be called unless the publisher explicitly calls MaxInterstitialAd#destroy() or MaxRewardedAd#destroy() - which most do not.
It is usually called when the "ad hidden" callback is fired from the mediate SDK - your SDK will need to be able to detect the Activity being dismissed and fire the "ad hidden" callback appropriately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Call onAdHidden method when onDestroy, because LINE SDK might close full-screen ad without calling onAdHidden method.
As a result,
This change fixes the above issue.
We verified patched LineMediationAdapter.java fixes the issue. The reproduced app with patched LineMediationAdapter.java does not reproduce the issue.