Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed rubocop-challenger #931

Closed

Conversation

m-nakamura145
Copy link
Contributor

It seems that rubocop-challenger has been disabled for the past four months.
https://github.com/Apipie/apipie-rails/actions/workflows/rubocop-challenger.yml

Since the rubocop workflow alone is functioning well, how about removing it?

@ekohl
Copy link
Member

ekohl commented Jun 17, 2024

@mathieujobin added this, so I'd like to get his opinion on this.

@mathieujobin
Copy link
Collaborator

I am disabling it to reduce noise as it creates many PR and takes time to review.

I also don't want to merge too many changes regularly.

I reenable manually to review suggestions from time to time.

I would like to keep it. We could update the schedule but I don't see a lot of value over manually disabling and reenabling.

Gracias

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants