-
Notifications
You must be signed in to change notification settings - Fork 463
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix param: Consider default_value: nil as valid config (#894)
* param: Consider default_value: nil as valid config When using `param` as: ```ruby param(:name, String, required: false, default_value: nil) ``` there would be a warning that `default_value` is missing. This fix changes from checking `options[key].blank?` to `options.key?(key)`. * Fixes rubocop warning * Fixes review comments
- Loading branch information
1 parent
ad2bc8d
commit 7cc859e
Showing
3 changed files
with
39 additions
and
14 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters