Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: make select_pragma_version public [APE-1530] #162

Merged
merged 4 commits into from
Nov 10, 2023
Merged

feat: make select_pragma_version public [APE-1530] #162

merged 4 commits into from
Nov 10, 2023

Conversation

antazoey
Copy link
Member

@antazoey antazoey commented Nov 9, 2023 •
edited
Loading

What I did

  • feat: make select_pragma_version public
  • fix: publish types (missing py.typed file)
  • chore: delete unused helper method

How I did it

How to verify it

Checklist

  • Passes all linting checks (pre-commit and CI jobs)
  • New test cases have been added and are passing
  • Documentation has been updated
  • PR title follows Conventional Commit standard (will be automatically included in the changelog)

@vany365 vany365 changed the title feat: make select_pragma_version public feat: make select_pragma_version public [APE-1530] Nov 9, 2023
@antazoey antazoey marked this pull request as ready for review November 9, 2023 22:01
@antazoey antazoey mentioned this pull request Nov 9, 2023
Merged
4 tasks
@antazoey antazoey merged commit 6abc325 into ApeWorX:main Nov 10, 2023
18 checks passed
@antazoey antazoey deleted the feat/more-stuff branch November 10, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NotPeopling2day NotPeopling2day NotPeopling2day approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antazoey @NotPeopling2day