Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

import solc versions installed via solc-select #136

Closed
wants to merge 3 commits into from

Conversation

f0rki
Copy link
Contributor

@f0rki f0rki commented Dec 10, 2021

What I did

Search the path used by solc-select for solidity versions to import.

Related issue: #122

How I did it

glob ~/.solc-select/artifacts for installed solc binaries.

How to verify it

$ rm -rf ~/.solcx ~/.solc-select
$ pip install solc-select
[...]
$ solc-select install 0.4.26 0.7.6
Installing '0.7.6'...
Version '0.7.6' installed.
Installing '0.4.26'...
Version '0.4.26' installed.
$ python -c 'import solcx; print(solcx.import_installed_solc())'
[Version('0.7.6'), Version('0.4.26')]

Checklist

  • I have confirmed that my PR passes all linting checks
  • I have included test cases
  • I have updated the documentation (README.md)
  • I have added an entry to the changelog

@f0rki
Copy link
Contributor Author

f0rki commented Dec 10, 2021

I am not sure on how to add test cases for this and whether this is even needed?

@f0rki
Copy link
Contributor Author

f0rki commented Dec 10, 2021

Somewhat related: it might be a good idea to use symlinks when sharing a lot of solc versions with solc-select. But I am not sure, whether this results in other issues.

Copy link

github-actions bot commented Dec 8, 2023

This pull request is considered stale because it has been open 30 days with no activity. Remove stale label, add a comment, or make a new commit, otherwise this PR will be closed in 5 days.

@github-actions github-actions bot added the stale label Dec 8, 2023
Copy link

This PR was closed because it has been inactive for 35 days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant