Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mixin mismatch #390

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix mixin mismatch #390

wants to merge 1 commit into from

Conversation

RuriYS
Copy link

@RuriYS RuriYS commented Oct 25, 2024

Description

Fix ModuleMixin to match Module.java

Related Issue

015efc60badfc647ebe67d6007f7824334668dd1

Motivation and Context

How Has This Been Tested?

  1. Built it
  2. Ran it (Both development and production)
  3. No more error.

crash log before changes:

[22:58:01] [main/ERROR]: Mixin apply for mod meteor-rejects failed meteor-rejects-meteor.mixins.json:ModuleMixin from mod meteor-rejects -> meteordevelopment.meteorclient.systems.modules.Module: org.spongepowered.asm.mixin.injection.throwables.InvalidInjectionException Invalid descriptor on meteor-rejects-meteor.mixins.json:ModuleMixin from mod meteor-rejects->@Inject::onInit(Lmeteordevelopment/meteorclient/systems/modules/Category;Ljava/lang/String;Ljava/lang/String;Lorg/spongepowered/asm/mixin/injection/callback/CallbackInfo;)V! Expected (Lmeteordevelopment/meteorclient/systems/modules/Category;Ljava/lang/String;Ljava/lang/String;[Ljava/lang/String;Lorg/spongepowered/asm/mixin/injection/callback/CallbackInfo;)V but found (Lmeteordevelopment/meteorclient/systems/modules/Category;Ljava/lang/String;Ljava/lang/String;Lorg/spongepowered/asm/mixin/injection/callback/CallbackInfo;)V [INJECT_APPLY Applicator Phase -> meteor-rejects-meteor.mixins.json:ModuleMixin from mod meteor-rejects -> Apply Injections ->  -> Inject -> meteor-rejects-meteor.mixins.json:ModuleMixin from mod meteor-rejects->@Inject::onInit(Lmeteordevelopment/meteorclient/systems/modules/Category;Ljava/lang/String;Ljava/lang/String;Lorg/spongepowered/asm/mixin/injection/callback/CallbackInfo;)V]

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My code follows the code style of this project.
  • Have you successfully ran tests with your changes locally?

@RuriYS RuriYS changed the title Fix mixin mismatch descriptor Fix mixin mismatch Oct 27, 2024
@Xenapte Xenapte mentioned this pull request Nov 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant