Skip to content

Adding build mode for structures #510

Adding build mode for structures

Adding build mode for structures #510

Triggered via pull request October 26, 2023 07:36
Status Failure
Total duration 8m 2s
Artifacts

rust.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

5 errors and 5 warnings
useless conversion to the same type: `bevy::prelude::Color`: cosmos_client/src/structure/ship/build_mode.rs#L295
error: useless conversion to the same type: `bevy::prelude::Color` --> cosmos_client/src/structure/ship/build_mode.rs:295:40 | 295 | ... color: Color::rgb(0.0, 0.0, 1.0).into(), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `Color::rgb(0.0, 0.0, 1.0)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
useless conversion to the same type: `bevy::prelude::Color`: cosmos_client/src/structure/ship/build_mode.rs#L270
error: useless conversion to the same type: `bevy::prelude::Color` --> cosmos_client/src/structure/ship/build_mode.rs:270:40 | 270 | ... color: Color::rgb(0.0, 1.0, 0.0).into(), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `Color::rgb(0.0, 1.0, 0.0)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
useless conversion to the same type: `bevy::prelude::Color`: cosmos_client/src/structure/ship/build_mode.rs#L245
error: useless conversion to the same type: `bevy::prelude::Color` --> cosmos_client/src/structure/ship/build_mode.rs:245:40 | 245 | ... color: Color::rgb(1.0, 0.0, 0.0).into(), | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `Color::rgb(1.0, 0.0, 0.0)` | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion = note: `-D clippy::useless-conversion` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::useless_conversion)]`
this `if` statement can be collapsed: cosmos_client/src/structure/ship/build_mode.rs#L37
error: this `if` statement can be collapsed --> cosmos_client/src/structure/ship/build_mode.rs:37:5 | 37 | / if local_player_in_build_mode.get_single().is_ok() { 38 | | if input_handler.check_just_pressed(CosmosInputs::ToggleBuildMode) { 39 | | client.send_message( 40 | | NettyChannelClient::Reliable, ... | 43 | | } 44 | | } | |_____^ | = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if = note: `-D clippy::collapsible-if` implied by `-D warnings` = help: to override `-D warnings` add `#[allow(clippy::collapsible_if)]` help: collapse nested if block | 37 ~ if local_player_in_build_mode.get_single().is_ok() && input_handler.check_just_pressed(CosmosInputs::ToggleBuildMode) { 38 + client.send_message( 39 + NettyChannelClient::Reliable, 40 + cosmos_encoder::serialize(&ClientReliableMessages::ExitBuildMode), 41 + ); 42 + } |
build
Clippy had exited with the 101 exit code
build
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/toolchain@v1, actions-rs/[email protected]. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
build
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
build
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
build
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
build
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/