Support interrupt transaction #993
Conversation
| expired = 1; | ||
| call_expiration_callback(); | ||
| } | ||
|
|
There was a problem hiding this comment.
Feels like this may introduce a possibility of the expiration callback being called twice? I am not sure how much that matters. Do we need to test_and_set both here and in the normal expiry path to guard against that?
There was a problem hiding this comment.
I was under the impression that it didn't matter to be called twice. Not sure how to exactly verify that. Maybe safest to do the test_and_set.
|
Note:start |
|
|
||
| void platform_timer::expire_now() { | ||
| bool expected = false; | ||
| if (expired.compare_exchange_strong(expected, true)) { |
There was a problem hiding this comment.
I guess you can save a line of code using atomic_flag, but it doesn't really matter
|
Support interrupt transaction |
Add support for interrupting a transaction in
apply_blockviactrl-corSIGINT/SIGTERM/SIGPIPE.Requires AntelopeIO/appbase#36
Resolves #985
Resolves #876