Nested attr supporting keys

[Isaac-Flath]

Added support for keys in nested_attr

@jph00

[review-notebook-app]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[jph00]

Can you look at the failing CI @Isaac-Flath ? Lemme know if you need help fixing it.

[jph00]

That was fast :)

[jph00]

Got another CI issue @Isaac-Flath !

[Isaac-Flath]

Argh, another issue. I am going to sleep on this and fix it in the morning. I will get the fastai testing figured out for local tests so I can test these integration tests that are failing before pushing the next attempt.

[Isaac-Flath]

@jph00 All tests pass now, but it feels like there should be a better way. I tried looking for a __getattr__ method and tried checking for types, but wasn't able to get something that worked reliably in all cases without doing the try and catching the exception if it happens.

[jph00]

@Isaac-Flath i think you want the hasattr() function

[Isaac-Flath]

I used it in some of the previous versions that were failing the integration tests, and tried several things using it and kept failing test so got rid of it. But I just added it back and it seems to work on local fastcore and fastai tests, so I must have been doing something different wrong.

Anyway - much better. Thank you!

[jph00]

Thanks @Isaac-Flath . In your other PR that uses this, please update settings.ini to require this version of fastcore , and at-mention when that's ready, and I'll release both.