Remove lxc-net dependency on Upstart service #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,7 +1,7 @@ | |||
| # Generated by Ansible for {{ansible_fqdn}} | |||
| description "Docker daemon" | |||
|
|
|||
| start on filesystem and started lxc-net | |||
There was a problem hiding this comment.
Not sure of the initial need for lxc-net but if anyone needs it (and I assume that originally it was needed) then it would be better if we could at least make it optional using a flag. On a related note, maybe that won't be needed depending on #3 .
|
I think this is fine. See #10 for future work. |
JasonGiedymin
added a commit
that referenced
this pull request
Dec 16, 2015
Remove lxc-net dependency on Upstart service
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the start dependency since Docker was not starting on boot (Ubuntu 14.04) as i do not have that service.