Skip to content

Commit

Permalink
Update chronos_conf.j2
Browse files Browse the repository at this point in the history 
Support spaces in MEM_OPTS.
  • Loading branch information
@jolexa
jolexa committed Jul 17, 2015
1 parent 5859e93 commit a23be67
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion templates/chronos_conf.j2
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
MEM_OPTS={{ chronos_runtime_memory_options }}
MEM_OPTS=\"{{ chronos_runtime_memory_options }}\"
LIB_PATH={{ chronos_runtime_lib_path }}
CHRONOS_JAR={{ chronos_runtime_chronos_jar }}
ZK_HOSTS={{ chronos_runtime_zookeeper_hosts }}
Expand Down

1 comment on commit a23be67

@jolexa
Copy link
Contributor Author

@jolexa jolexa commented on a23be67 Jul 17, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sigh, this was a bad change. I am deep in the trenches trying to test the deployment so my perceived testing was only thought to be working.

MEM_OPTS="{{ chronos_runtime_memory_options }}" - literally leaves " in the final file
MEM_OPTS=""{{ chronos_runtime_memory_options }}"" - literally leaves "" in the final file
MEM_OPTS="{{ chronos_runtime_memory_options }}" - drops the quotes and leaves spaces in the final file

Only method 2 is safe and chronos will start at the expense of being ugly.

Please sign in to comment.