-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: ✨ add initial configuration files for various tools and linters #1746
Conversation
Changed Files
|
Reviewer's Guide by SourceryThis PR introduces initial configuration files for various development tools and linters using Trunk as the primary configuration management system. The implementation focuses on setting up a comprehensive set of linting and code quality tools with specific configurations for Python, JavaScript, Docker, Markdown, and shell scripts. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Anselmoo - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider consolidating Python linting tools - having ruff, pylint, and black might be redundant. Ruff can handle most of pylint's checks with better performance.
- Consider adding documentation explaining the chosen tools and their versions to help future maintainers understand the decisions made.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1746 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 45 45
Lines 4520 4520
=========================================
Hits 4520 4520
Flags with carried forward coverage won't be shown. Click here to find out more. |
All PR-Submissions:
Pull Requests for the same
update/change?
New ✨✨ Feature-Submissions:
Changes to ⚙️ Core-Features:
us to include them?
Summary by Sourcery
Add initial configuration files for Trunk and various linters and tools to set up project standards and automation.
Build:
Chores: