-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: ✨ add GitHub Actions workflow for Conda package builds #1736
Conversation
Reviewer's Guide by SourceryThis PR adds a new GitHub Actions workflow that automates the testing of Conda package installations for different variants of the spectrafit package. The workflow runs on every push and tests the installation of four different package configurations using Conda-forge channel. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Anselmoo - I've reviewed your changes - here's some feedback:
Overall Comments:
- Consider upgrading actions/setup-python from v3 to v4 for latest features and security updates
- Instead of updating the base environment, consider creating a new conda environment to avoid potential conflicts and improve reproducibility
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
@@ -0,0 +1,32 @@ | |||
name: Python Package using Conda | |||
|
|||
on: [push] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion (performance): Consider adding path filters to the workflow trigger
Limiting the workflow to run only when relevant files change (like setup.py, environment.yml, or package source files) would reduce unnecessary CI runs
on: [push] | |
on: | |
push: | |
paths: | |
- '**.py' | |
- 'setup.py' | |
- 'setup.cfg' | |
- 'pyproject.toml' | |
- 'environment.yml' | |
- 'conda/**' | |
- '.github/workflows/**' |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1736 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 45 45
Lines 4520 4520
=========================================
Hits 4520 4520
Flags with carried forward coverage won't be shown. Click here to find out more. |
Quality Gate passedIssues Measures |
All PR-Submissions:
Pull Requests for the same
update/change?
New ✨✨ Feature-Submissions:
Changes to ⚙️ Core-Features:
us to include them?
Summary by Sourcery
CI: