new multiclam function with test #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
new multiclam function with test
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
0xPilou
approved these changes
Feb 20, 2024
src/royalty/ABClaim.sol
Outdated
| for (uint256 i; i < dLength;) { | ||
| uint256 dropId = _dropIds[i]; | ||
|
|
||
| for (uint256 i; i < _dropIds.length;) { |
There was a problem hiding this comment.
have you tried to store _dropIds.length in a var ?
does it give you stack too deep ?
if not, it could gas optimize a little
src/royalty/ABClaim.sol
Outdated
| for (uint256 j; j < _tokenIds[i].length;) { | ||
| // Enforce token ownership | ||
| if (ownerOf[dropId][_tokenIds[i][j]] != _user) revert ABErrors.NOT_TOKEN_OWNER(); | ||
| for (uint256 j; j < tokenIds.length;) { |
test/royalty/ABClaim.t.sol
Outdated
| @@ -940,6 +940,59 @@ contract ABClaimTest is Test { | |||
| assertEq(abClaim.getClaimableAmount(dropIds, uTokenIds), 0); | |||
| } | |||
|
|
|||
| function test_claim_multiScaleBaseDrop(address _sender, address u1, uint256 scaleAmount) public { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.