Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AB-723 : Standalone Royalty Claiming contract #26

Merged
merged 43 commits into from
Feb 22, 2024
Merged

Conversation

0xPilou
Copy link
Contributor

@0xPilou 0xPilou commented Jan 29, 2024

New Royalty contracts with following features :

  • royalties are tied to a tokenId and not an EOA
  • 1 contracts for all existing drops
  • can claim all drops at once

@0xPilou 0xPilou requested a review from jonathangus January 29, 2024 08:30
Copy link

openzeppelin-code bot commented Jan 29, 2024

AB-723 : Standalone Royalty Claiming contract

Generated at commit: d99367ea9f0a94c4e2700c05ed2a1e352b638c9e

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
1
0
0
3
21
25
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
2
56
58

For more details view the full report in OpenZeppelin Code Inspector

Copy link
Contributor

@jonathangus jonathangus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@0xPilou 0xPilou requested a review from jonathangus February 22, 2024 13:18
@0xPilou 0xPilou merged commit 4360a91 into dev Feb 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants