Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AB Platform v1.1 upgrade #18

Merged
merged 61 commits into from
Nov 9, 2023
Merged

AB Platform v1.1 upgrade #18

merged 61 commits into from
Nov 9, 2023

Conversation

jonathangus
Copy link
Contributor

No description provided.

@0xPilou
init draft
cd038b5
@0xPilou
updated getPayoutDetails
f1e0642
@0xPilou
cache
c281abd
@0xPilou
remove unused imports
09dd824
@0xPilou
updated withdraw to rightholder args
a36a005
@0xPilou
cache
7daab67
@0xPilou
added setDropFee function
ad04197
@0xPilou
cache
afa707e
@0xPilou
disable solhint in tests scripts
ed74d3a
@0xPilou
disable solhint in tests scripts
94509de
@0xPilou
added coverage for drop specific fees
b927456
@0xPilou
increased coverage withdrawRightholder
7c4cdb6
@0xPilou
dataregistry lcov
bcfdaff
@0xPilou
updated getPayoutDetails coverage
41680d9
@0xPilou
added collaboration workflow to README
4688930
@0xPilou
draft ERC721AB OpenEdition contract
f272289
@0xPilou
added test coverage for ERC721AB OpenEdition
2a995b2
@0xPilou
fix typo
c779b5e
@0xPilou
migrate ERC721AB to abstract contract
80e9c33
@0xPilou
draft limited edition contract (ex-ERC721AB)
3292517
@0xPilou
Merge pull request #13 from Anotherblock/ab456-dropIdFee
dfc76dc 
AB-456 : DropId specific fees
@0xPilou
Merge branch 'dev' into ab558-standardNFT
e800b95
@0xPilou
remove unnecessary imports
9b5bebb
@0xPilou
updated deploy scripts
51791e0
@0xPilou
rename test data
b39838c
@0xPilou
updated test scripts
b91c987
@0xPilou
cache
4500246
@0xPilou
added implementation type constant state
ff13a4f
@0xPilou
rename implementation type
786d1b7
@0xPilou
reviewed ERC721ABLE and ERC721AB (initDrop)
9321342
0xPilou added 22 commits October 2, 2023 09:54
@0xPilou
cache
c942191
@0xPilou
remove MAX_MINT checks in mint
aa72be7
@0xPilou
remove unit test for max mint check in ERC721ABOE
86f5dac
@0xPilou
cache
e52758d
@0xPilou
Merge pull request #14 from Anotherblock/ab557-oe
b57ee48 
AB-557 : Open Edition NFT contract
@0xPilou
updated deployment addresses
3a93627
@0xPilou
cache
cec81dc
@0xPilou
added deploy upgrade script
efa12ab
@0xPilou
deployed upgrade on base goerli
26e9f7b
@0xPilou
added predict impl address
b6758af
@0xPilou
cache
35d790c
@0xPilou
update config for fuzz.seed
946c9c7
@0xPilou
update foundry config : fuzz.seed
1c0c178
@0xPilou
fix foundry config
ff51f59
@0xPilou
Merge pull request #16 from Anotherblock/ab677-predictImplAddress
3c1a04d 
AB-677 : predict address from implementation
@0xPilou
fix access control issue in CreatePublisherProfile function
444c7ff
@0xPilou
cache
9073fca
@0xPilou
Merge pull request #17 from Anotherblock/ab390-createPublisherRole
3a8a171 
AB-390 : create publisher role fix
@0xPilou
deploy new factory
80902b8
@0xPilou
added check on mint
d224a76
@0xPilou
cache
a681df0
@0xPilou
v1.1 deployment script
4666a87
@0xPilou 0xPilou changed the title update AB Platform v1.1 upgrade Nov 7, 2023
jonathangus
jonathangus commented Nov 8, 2023
View reviewed changes
Copy link
Contributor Author

@jonathangus jonathangus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should sharePerToken and royaltyCurrency exist in the base contract. If so we green ✅

src/token/ERC721/ERC721AB.sol Show resolved Hide resolved
@jonathangus jonathangus marked this pull request as ready for review November 9, 2023 07:46
@jonathangus jonathangus merged commit 9212da9 into latest Nov 9, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xPilou 0xPilou 0xPilou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonathangus @0xPilou