Skip to content

Commit

Permalink
added events in approveERC721Implementation & `updateERC721Implemen…
Browse files Browse the repository at this point in the history
…tation`
  • Loading branch information
0xPilou committed Dec 12, 2023
1 parent 3299f4b commit 55eb985
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 1 deletion.
2 changes: 1 addition & 1 deletion forge-cache/solidity-files-cache.json

Large diffs are not rendered by default.

2 changes: 2 additions & 0 deletions src/factory/AnotherCloneFactory.sol
Original file line number Diff line number Diff line change
Expand Up @@ -313,6 +313,7 @@ contract AnotherCloneFactory is AccessControlUpgradeable {
{
_newImplementationId = erc721ImplAddresses.length;
erc721ImplAddresses.push(_newImpl);
emit ABEvents.UpdatedERC721Implementation(_newImplementationId, _newImpl);
}

/**
Expand All @@ -328,6 +329,7 @@ contract AnotherCloneFactory is AccessControlUpgradeable {
onlyRole(DEFAULT_ADMIN_ROLE)
{
erc721ImplAddresses[_implementationId] = _newImpl;
emit ABEvents.UpdatedERC721Implementation(_implementationId, _newImpl);
}

/**
Expand Down
3 changes: 3 additions & 0 deletions src/libraries/ABEvents.sol
Original file line number Diff line number Diff line change
Expand Up @@ -56,4 +56,7 @@ library ABEvents {

/// @dev Event emitted upon publisher fee updates
event PublisherFeesUpdated(address publisher, uint256 fee);

/// @dev Event emitted upon approving or updating an ERC721 implementation within AnotherCloneFactory
event UpdatedERC721Implementation(uint256 implementationId, address implementationAddress);
}

0 comments on commit 55eb985

Please sign in to comment.