Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐞[Bug]: Fixing News.html #878

Merged
merged 5 commits into from
Jul 15, 2024
Merged

🐞[Bug]: Fixing News.html #878

merged 5 commits into from
Jul 15, 2024

Conversation

Anjaliavv51
Copy link
Contributor

@Anjaliavv51 Anjaliavv51 commented Jul 15, 2024

#873

Description

[Please include a brief description of the changes or features added]

Related Issues

[Cite any related issue(s) this pull request addresses. If none, simply state “None”]

Type of PR

  • Bug fix
  • Feature enhancement
  • Documentation update
  • Other (specify): _______________

Screenshots / videos (if applicable)

Vercel Deployment screenrecording

WhatsApp.Video.2024-07-15.at.16.58.53_8f42ebcb.mp4

Checklist

  • I have gone through the contributing guide
  • I have updated my branch and synced it with project main branch before making this PR
  • I have performed a self-review of my code
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Copy link

vercel bot commented Jul 15, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rapidoc ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 15, 2024 11:46am

Copy link

netlify bot commented Jul 15, 2024

Deploy Preview for rapidoc ready!

Name Link
🔨 Latest commit 0809d34
🔍 Latest deploy log https://app.netlify.com/sites/rapidoc/deploys/66950c242fe97000081c3649
😎 Deploy Preview https://deploy-preview-878--rapidoc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @Anjaliavv51! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

updates nav in new.html file
nav updation , to fix the alignment
@Anjaliavv51
Copy link
Contributor Author

@varshith257 please review the PR and also please check the deployment screen recording vercel app.

@varshith257
Copy link
Collaborator

@Anjaliavv51 Why footer is blue?

@Anjaliavv51
Copy link
Contributor Author

@varshith257

image

@Anjaliavv51
Copy link
Contributor Author

@varshith257 changes are done.

@varshith257
Copy link
Collaborator

Why's there gap between footer and news section and also the gap between footer and end of page?

Also make hover me or readme buttons to center of card

@varshith257 varshith257 added gssoc level3 hard (new feature) labels Jul 15, 2024
#873
gaps between footer and other tags
@Anjaliavv51
Copy link
Contributor Author

Anjaliavv51 commented Jul 15, 2024

@varshith257

image

image

It is fixed.

@varshith257 varshith257 changed the title 🐞[Bug]: Fixing New.html 🐞[Bug]: Fixing News.html Jul 15, 2024
@varshith257 varshith257 merged commit cf838c8 into Anishkagupta04:main Jul 15, 2024
7 checks passed
Copy link
Contributor

🎉 Your pull request has been successfully merged! 🎉 Thank you for your contribution to our project. Your efforts are greatly appreciated. Keep up the fantastic work! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc level3 hard (new feature)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐞[Bug]: Fixing New.html
2 participants