improved the background of the login page #838
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Great job, @aditya-bhaumik! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines
✅ Deploy Preview for rapidoc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Please review my pull request @varshith257 @Anishkagupta04 |
|
Hey @aditya-bhaumik , it's good with it's color scheme matching with project. Can you remove the animation and keep static color matching with color scheme ? You can also make it mobile responsive it's looking really bad in mobile view of login/sign up page |
|
@varshith257 Sure, I’ll make the changes and let you know as soon as I can. |
|
@varshith257 i have made the background static and now the page is more responsive then before
|
|
See here some line is appearing in the middle of page . I think it is due usage of gradient |
|
For mobile response I think we have to make text size small and same buttons and social media icons to better align with mobile screen |
|
@varshith257 now the line should not be coming i made the text and all small can you check again for different devices |
|
i checked in mine for different devices and it is looking good in all of them
|
Exactly here I think we have to define multiple media screens if needed to inline the remember me and forgot password could align in one line |
|
@varshith257 hi i tried to align the 2 text in same line but no matter how many media queries i add there are some screens where these 2 are not coming in same line i tried changing the font size and all but it just makes the text smaller it does not get it in one line |
|
@aditya-bhaumik Have you tried with reducing text sizes where isn't aligning |
|
@varshith257 yes it is just making text smaller it is not getting them in the same line |
|
|
|
@varshith257 i added the login.html to the log folder and removed the duplicate script code i also tried the labels you mentioned but the result is same as before |
|
Ok, let's come to it later. I have no time to see what's the cause of it |
|
🎉 Your pull request has been successfully merged! 🎉 Thank you for your contribution to our project. Your efforts are greatly appreciated. Keep up the fantastic work! 🚀 |
|
@varshith257 There was just a small change left that I was making before the code got merged. In the index.html, the link was supposed to be log/login.html to link the login page can you please make that small change |
|
Submit follow up PR with this change |
|
@varshith257 added it in #855 |
Description
i have added hover effect to the social icons and the home button
I have added a linear gradient background
i have added a wave animation to the new linear background
Related Issues
[Cite any related issue(s) this pull request addresses. If none, simply state “None”]
Type of PR
Screenshots / videos (if applicable)
Before :
After :
The background is continuously moving
Checklist
mainbranch before making this PRAdditional context:
[Include any additional information or context that might be helpful for reviewers.]