updated home page css #800
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
✅ Deploy Preview for rapidoc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Great job, @dhairyagothi! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines
|
@varshith257 please check this |
|
I will review it by EOD. Till then I will tag @Anishkagupta04 for review |
|
And a quick review, the Footer is looking large, and there is still to be improved and patient login and appointment form i think you can reduce long blocks and give padding without sticking it to the homepage |
|
what changes you want can you please share ss of changes you want for better understanding i think its look good in my mobile phone |
|
@varshith257 please check this |
|
To keep better for testimonials better implement < and > buttons to make easier for users to switch testimonials and also if needed add some timeout to move them automatically. And for footer all links keep in a same row move the below Legal Section to above 3 in a row and keep subscribe news letter to left and move footer details and social links to left if needed. Appointment form you can reduce the size of it. It looking like sticked in home page PS: I am not going with technical aspects. I am on other works. So given a wrap up feedback :) Tag me if you need any explanation of them |
okay @varshith257 i will do changes about footer i think its look good in mobile view . i have made changes only for mobile view :) |
|
I am referencing for the same for mobile view and it's feel like footer is big so make those changes let's see how it results |
|
@varshith257 now check bro :| |
|
@varshith257 please check it and tell me if anything else i have to change else please merge the PR |
|
The news letter subscribe elements can be expanded horizontally like Text within 2 lines. Mail box. Subscribe button |
|
And social media buttons move to center and any updates of testimonials section? |
ya i am trying to increase it width |
|
any other changes needed @varshith257 ? |
|
It's fine with adjusting above changes. If you feel difficulty for testimonials section. Raise a new issue and I will send sample design of it |
|
|
|
I mean newsletter section should expanded horizontally something like this Text. ----->. Mail box. --->. Subscribe Button |
|
@varshith257 check this i think it is
this one @varshith257 |
|
@dhairyagothi You got it wrong. Ahh, something like below:
|
|
@varshith257 now : ) |
|
@dhairyagothi Once see the screenshot we attached you can reduce the sizes of them in the mobile view |
what i have to do i dont get it ? |
|
In media width make email block and subscribe button side by side as attached in the image and you can reduce their sizes in media screen |
|
@varshith257 any other changes needed ? |
|
@varshith257 check this |
|
@varshith257 please merge the PR |
|
@dhairyagothi The footer got misaligned. Check in the deploy |
IT IS ASKING FOR ACCESS |
|
Check it in netifly deployment in above. Vercel couldn't be accessed
…On Wed, 10 Jul, 2024, 10:41 pm Dhairya Gothi, ***@***.***> wrote:
@dhairyagothi <https://github.com/dhairyagothi> The footer got
misaligned. Check in the deployI
IT IS ASKING FOR ACCESS
—
Reply to this email directly, view it on GitHub
<#800 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A4BF3HCIL7WKPFZISRZA3GTZLVTL5AVCNFSM6AAAAABKSBINEOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMRRGA2TAMZYGM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***
com>
|
|
fixed @varshith257 |
|
🎉 Your pull request has been successfully merged! 🎉 Thank you for your contribution to our project. Your efforts are greatly appreciated. Keep up the fantastic work! 🚀 |
Description
Fixed
Recording.2024-07-09.095827.mp4
[Please include a brief description of the changes or features added]
Related Issues
[Cite any related issue(s) this pull request addresses. If none, simply state “None”]
Type of PR
Screenshots / videos (if applicable)
[Attach any relevant screenshots or videos demonstrating the changes]
Checklist
mainbranch before making this PRAdditional context:
[Include any additional information or context that might be helpful for reviewers.]