Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Privacy Policy Page #752

Merged
merged 3 commits into from
Jul 3, 2024
Merged

Conversation

aslams2020
Copy link
Contributor

@aslams2020 aslams2020 commented Jul 3, 2024

Hey @Anishkagupta04 , @varshith257
issue closes #742

Below are the Changes I Implemented :

  1. Replaced all the ul, li tags with Paragraphs for better alignment of Page.
  2. Added Extra Styling to the page so that to follow the website theme.
  3. I also added a favicon to the page.
  4. I also Created a footer at the bottom with much needed links.
  5. Additionally, I added "Home" to the footer to easily navigate to the home page.

With This Changes, The privacy policy page now follows the Theme of the website with much better alignment!

Please take a look -

Uploading rapidoc privacy (1) (1).mp4…

Please take a look and review it.
Thankyou!

  • Feature enhancement

Checklist

  • I have gone through the contributing guide
  • I have updated my branch and synced it with project main branch before making this PR
  • I have performed a self-review of my code
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Copy link

vercel bot commented Jul 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rapidoc ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 3, 2024 9:44pm

Copy link

netlify bot commented Jul 3, 2024

Deploy Preview for rapidoc ready!

Name Link
🔨 Latest commit 634cbd4
🔍 Latest deploy log https://app.netlify.com/sites/rapidoc/deploys/6685c6444e76c10007c224ef
😎 Deploy Preview https://deploy-preview-752--rapidoc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @aslams2020! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

@varshith257
Copy link
Collaborator

@aslams2020 Can you also add the existing navbar and footer of the home page to the Privacy Policy Page. Will award level 3 by incorporating it.

@varshith257 varshith257 added gssoc level3 hard (new feature) labels Jul 3, 2024
@aslams2020
Copy link
Contributor Author

Sure! @varshith257 , I will do that.

@aslams2020
Copy link
Contributor Author

aslams2020 commented Jul 3, 2024

Done @varshith257

rapidoc.privacy.navfoot.mp4

@varshith257 varshith257 merged commit f4ccb79 into Anishkagupta04:main Jul 3, 2024
6 checks passed
Copy link
Contributor

github-actions bot commented Jul 3, 2024

🎉 Your pull request has been successfully merged! 🎉 Thank you for your contribution to our project. Your efforts are greatly appreciated. Keep up the fantastic work! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc level3 hard (new feature)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

➕ Feature: Styling the "Privacy Policy" Page to Match the Theme
2 participants