Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of navbar and footer and improvement in the ui of signin and signup page that match the theme #682

Closed
wants to merge 6 commits into from

Conversation

DiwareNamrata23
Copy link
Contributor

@DiwareNamrata23 DiwareNamrata23 commented Jun 24, 2024

Description

Added navbar and footer also changed background colour

Related Issues

[Cite any related issue(s) this pull request addresses. If none, simply state “None”]

Type of PR

  • Feature enhancement

Screenshots / videos (if applicable)

[Attach any relevant screenshots or videos demonstrating the changes]
Screenshot 2024-06-24 at 3 02 52 PM
Screenshot 2024-06-24 at 3 30 04 PM

Checklist

  • I have gone through the contributing guide
  • I have updated my branch and synced it with project main branch before making this PR
  • I have performed a self-review of my code
  • I have tested the changes thoroughly before submitting this pull request.
  • I have provided relevant issue numbers, screenshots, and videos after making the changes.
  • I have commented my code, particularly in hard-to-understand areas.

Additional context:

[Include any additional information or context that might be helpful for reviewers.]

Copy link

vercel bot commented Jun 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rapidoc ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 25, 2024 4:02pm

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, @DiwareNamrata23! 🎉 Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.We will promptly review your changes and offer feedback. Keep up the excellent work! Kindly remember to check our contributing guidelines

Copy link

netlify bot commented Jun 24, 2024

Deploy Preview for rapidoc ready!

Name Link
🔨 Latest commit 4f8c41c
🔍 Latest deploy log https://app.netlify.com/sites/rapidoc/deploys/66a277045699270008b8e709
😎 Deploy Preview https://deploy-preview-682--rapidoc.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@DiwareNamrata23
Copy link
Contributor Author

@varshith257 plz review my pr

@varshith257
Copy link
Collaborator

Will review it soon

@varshith257
Copy link
Collaborator

@Anishkagupta04 PTAL

@DiwareNamrata23
Copy link
Contributor Author

Does ay changes required @varshith257 & @Anishkagupta04 please let me know..

@varshith257
Copy link
Collaborator

@DiwareNamrata23 The navbar seems the old one. Please update with upstream and use the new one

@DiwareNamrata23
Copy link
Contributor Author

Sure

@DiwareNamrata23
Copy link
Contributor Author

@varshith257 done the changes please tell me the required changes

@Anishkagupta04
Copy link
Owner

the navbar is different also the color is not same as in website and the header is also not same

@varshith257
Copy link
Collaborator

the navbar is different also the color is not same as in website and the header is also not same

@DiwareNamrata23 Any updates on this?

@DiwareNamrata23
Copy link
Contributor Author

Yes added changes in color will commit in few hours by today

@DiwareNamrata23
Copy link
Contributor Author

Screenshot 2024-07-25 at 9 33 01 PM Screenshot 2024-07-25 at 9 33 10 PM added the changes plz review @varshith257 and @Anishkagupta04

@varshith257
Copy link
Collaborator

@DiwareNamrata23 Can you solve merge conflicts and tag me?

@DiwareNamrata23 DiwareNamrata23 closed this by deleting the head repository Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants